You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the test_only conditional compilation feature and make it part of the CLI arguments instead. Technically not related to continuations, but there are enough differences with develop that we might as well merge it here to avoid rebasing later.
Technically not related to continuations, but there are enough differences with develop that we might as well merge it here to avoid rebasing later.
It will probably conflict with latest changes on develop (rpc input per block). I think continuations branch should only take continuations related changes since it will probably not be merged to develop for some time (weeks?), while we continue to develop zero_bin on develop
It won't be released for a few weeks but I'd rather see it on develop sooner than later given that's its not showing any sign of regression vs develop and conflicts all the time with incoming refactorings from Aatif
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hratoanina
requested review from
muursh,
Nashtare and
atanmarko
as code owners
github-actions
bot
added
the
crate: zero_bin
Remove the
test_onlyconditional compilation feature and make it part of the CLI arguments instead. Technically not related to continuations, but there are enough differences withdevelopthat we might as well merge it here to avoid rebasing later.Includes #288.