Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with the pairing computations #554

Closed
hratoanina opened this issue Aug 27, 2024 · 0 comments · Fixed by #579
Closed

Issue with the pairing computations #554

hratoanina opened this issue Aug 27, 2024 · 0 comments · Fixed by #579
Assignees
@Nashtare
Labels
bug Something isn't working crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Milestone
Testing and Valid...

Comments

@hratoanina
Copy link
Contributor

In the pairing tests:

zk_evm/evm_arithmetization/src/curve_pairings.rs

Line 987 in 32a6ba7

mod tests {

In the edge case where acc is 0 and thus p is the point at infinity, we get conflicting behaviors: bls381::ate_optim(p, q) returns Fp12::UNIT while bn254::tate(p, q) returns Fp12::ZERO. One of them is wrong.
@hratoanina hratoanina added bug Something isn't working crate: evm_arithmetization Anything related to the evm_arithmetization crate. labels Aug 27, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Aug 27, 2024
@Nashtare Nashtare added this to the Testing and Validation milestone Aug 28, 2024
@Nashtare Nashtare mentioned this issue Sep 1, 2024
Merged
@Nashtare Nashtare self-assigned this Sep 1, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Zero EVM Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nashtare Nashtare

Labels
bug Something isn't working crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Zero EVM
Status: Done
Milestone
Testing and Validation
Development

Successfully merging a pull request may close this issue.

Fix pairing tests for null accumulated values 0xPolygonZero/zk_evm
2 participants
@hratoanina @Nashtare