Fix pairing tests for null accumulated values #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
muursh
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue arising in some randomized samples of the pairing test was that the accumulated scalar was ending to be 0.
As we normalize the accumulated pairing computation by multiplying the running product by
pairing(-acc.P, Q), this was yielding invalid results forbn254, as the infinity point is not a valid curve point and hence the pairing operation wasn't actually defined for-acc.P.The issue only affected the updated test, the KERNEL implementation is sound as checking input validity, and is being tested expecially against these cases with
test_ecpairing_precompile_invalid_input.closes #554