smt generation #127
smt generation #127
Conversation
github-actions
bot
added
the
crate: trace_decoder
github-actions
bot
added
the
crate: evm_arithmetization
|
|
Shouldn't we perhaps redirect this to the |
|
@temaniarpit27 What's the status of this? |
Brendan Gluth and I discussed regarding this. SMT format was earlier structured into MPT format (HashedPartialTrie). But today while discussing, a new structure will be formed by Brendan which will contain the SMT trie. The discussion is already happening on our internal slack channel. |
BGluth
force-pushed
the
arpit/pos-2512
branch
2 times, most recently
from
1f1dd97 to
4c9b2b8
Compare
|
I had already mentioned it above, but I think it should be targeted against |
temaniarpit27
force-pushed
the
arpit/pos-2512
branch
from
7cebfbf to
835833d
Compare
github-actions
bot
removed
the
crate: evm_arithmetization
- Created type aliases for all `evm_arithmetization` types that we need to swap out depending on whether or not we are compiling for `mpt` or `smt`.
- Realized that there is no clean way to disable a default feature when it absolutely needs to be disabled (eg. when "smt" is enabled). - Also added a compile time check to enforce that one of these features is enabled.
- Prep for `mpt`/`smt` logic feature gating.
- Realized that we can link again both versions of the library at once without conditional compilation.
- It's going to make a lot of sense I think to split the logic that generates `mpt` & `smt` tries. This commit just renames a file and creates the module for smt tries.
- Because we're going to be dealing with feature flags for SMT stuff, it's going to be very worth while I think splitting the logic into seperate modules. - This commit does just that.
- We need to access this normally with a feature gate, but just to rush getting something going, we're going to copy it in for now.
- Realized that all hash inserts must occur before leaf inserts in the smt library.
- Now it's clear if the test is for MPT or SMT.
- Note that processing & decoding still needs to be done.
github-actions
bot
added
the
crate: mpt_trie
|
Ready to me merged once #197 is merged back in. |
github-actions
bot
added
the
crate: evm_arithmetization
There was a problem hiding this comment.
This PR is really confusing in it's current form. I'm really struggling to tell what I should be looking at. Almost everything I've seen so far seems to be from other PRs.
I'm also finding it difficult to understand how the smt amd mpt code is meant to live together here.
github-actions
bot
removed
the
crate: mpt_trie
|
Closing as we are instead going to combine this with #206, as this PR on it's own is a bit confusing. |
No description provided.