Revert "Simplify withdrawals logic (#168)" #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d547c2e.
github-actions
bot
added
the
crate: trace_decoder
|
As discussed with @BGluth when exploring the issue, we should consider yanking the current version of the decoder once a new version including this reversal is published. |
muursh
approved these changes
Apr 20, 2024
|
@muursh of course when I open a PR I found the issue that was blocking me in fixing it instead of reverting. Let me confirm, and if so I'll override this PR with an actual fix. |
|
Superseeded by #176. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The withdrawals logic change in #168 is actually not correct as it's missing initial trie state update to include withdrawals state accesses, but for some reasons I can't get it to work yet so I'd rather revert this PR for the time being.