Introduce verify_all_proofs and update integration tests #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
Nashtare
approved these changes
Apr 25, 2024
evm_arithmetization/src/verifier.rs
Outdated
| @@ -116,13 +116,32 @@ fn verify_initial_memory< | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn verify_proof<F: RichField + Extendable<D>, C: GenericConfig<D, F = F>, const D: usize>( | |||
| pub fn verify_all_proofs< | |||
There was a problem hiding this comment.
I'd rather put this in a testing module, similarly to prove_all_segments as it isn't aimed to be used outside of testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
verify_all_proofsand updates integration tests with this method.