refactor!: docker builds

[0xaatif]

This blocks #309

Breaking changes

• we now only publish one image, which contains rpc, worker, verifier, and leader, rather than separate worker and leader containers. Users may have to select an ENTRYPOINT or pass additional parameters to their run command
• we don't include the .env file from the repo in our docker build

Change summary:

• gets rid of this awful hack:

  zk_evm/zero_bin/leader/src/utils.rs

  Lines 45 to 72 in 653b7e4

  	pub(crate) fn get_package_version(package_name: &str) -> Result<Option<String>> {
  	let manifest_dir = env!("CARGO_MANIFEST_DIR");
  	let zero_bin_path = Path::new(manifest_dir)
  	.join("../") // Adjust the path according to your workspace structure
  	.canonicalize()?;
  	let cargo_lock_path = zero_bin_path.join("Cargo.lock");
  	let cargo_lock_file = File::open(cargo_lock_path);
  	if cargo_lock_file.is_err() {
  	return Ok(None);
  	}
  	let mut cargo_lock_contents = String::new();
  	BufReader::new(cargo_lock_file?).read_to_string(&mut cargo_lock_contents)?;
  	let lockfile: toml::Value = toml::from_str(&cargo_lock_contents)?;
  	if let Some(package) = lockfile["package"]
  	.as_array()
  	.unwrap()
  	.iter()
  	.find(|&p| p["name"].as_str() == Some(package_name))
  	{
  	let version = package["version"].as_str().unwrap();
  	return Ok(Some(version.to_string()));
  	}
  	Ok(None)
  	}

  • reviewers, I'm not sure why we don't just have this in evm_arithmetization/src/lib.rs: can anyone educate me?

    pub const VERSION: &str = env!("CARGO_PKG_VERSION");

• one Dockerfile, with:
  • configuration for e.g cargo build --dev
  • best practices for caching, user config, .dockerignore, apt install...
  • no more sediting our Cargo.toml with a 200-character long command
  • (more) loosely coupled to our code, so e.g whitespace changes(!), new workspace packages etc don't break docker builds
• one place for RUSTFLAGS

[atanmarko]

👌 for the github release image. We will use it as discussed and agreed.

[atanmarko]

@Nashtare @BGluth Should check the evm_arithmetization versioning, I believe they have discussed it before.

[Nashtare]

I see you moved the disabling of lld linker in config.toml but why removing -C target-cpu=native. This should be disabled when building cross-platform images, but it doesn't hurt keeping it in the scripts.

[0xaatif]

I'll take your lead on this

[Nashtare]

I believe this bit sets the entire version number, i.e. X.Y.Z while we're not interested in the patch section. Any increment of Z should not yield circuits regeneration.

[0xaatif]

I don't know the code that reads this, but I thought it would be safer (and rare enough) to include. I'll take your lead on this.

[0xaatif]

#368

[Nashtare]

LGTM on the versioning part.