perf(continuations): Improve initializations and reduce redundant computations #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…45336afd not found in linked list
…ert_storage_change
github-actions
bot
added
crate: trace_decoder
Nashtare
commented
Jul 23, 2024
Nashtare
commented
Jul 25, 2024
Nashtare
added a commit
that referenced
this pull request
Aug 6, 2024
…putations (#429) * [WIP] add account to linked list * Add account linked list and some unit tests * Modify tests for insetions and fix bugs * Fix deletion test * [WIP] Getting trie data without leaves * [WIP] changes during the flights * Fix storage ll error * Add missing file * [WIP] checking consistency between linked list and state trie * [WIP] addr 0x798c6047767c10f653ca157a7f66a592a1d6ca550cae352912be0b0745336afd not found in linked list * [WIP] add missing nibbles to key * Fix accounts insertions * Check storage reads * Add segments to preinitialization * [WIP] Unreasonable offset * [WIP] Erc721 error * [WIP] uncomment ll reads * [WIP] Fixing iterator * Fix unit tests * Fix erc721 error * mend * Remove debug info * mend * [WIP] hashing * Provide constants non-deterministically * Update journaling * Update search_account and read_accounts_linked_lists * Constraint state and storage leaves * Update slot and account search methods in linked_lists and update revert_storage_change * Fix asm * Some fixes and debugging * Fix hash mismatch * Add functions for updating final trie * [WIP] eliminating trie call * [WIP] Fix kexit_data issue * Merge with journaling branch * [WIP] set final tries * Mutate storage payload on insertions * Fix deletions in final trie computation * Remove double hashing of the initial state trie * Misc * trace_decoder/Cargo.toml * Fix return from read_storage_linked_list_w_addr * [WIP] debugging unit tests * Fix set_payload_storage_extension and bring back final gas check * Fix failing shanghai blocks * Fix run_next_addresses_remove and some revertions * Some journaling fixes * FIx revert_storage_change and revert_account_created * Fix delete account * [WIP] fixing LoopCallsDepthThenRevert3_d0g0v0_Shanghai.json * Add an overwrite version of account insertion and use it for mpt_insert_state_trie * Fix final state trie hash mismatch * Fix insert_new_slot_with_value * Debugging variedContext_d10g0v0_Shanghai.json * Fix variedContext_d10g0v0_Shanghai * [WIP] Fixing vitalikTransactionTestParis_d0g0v0_Shanghai * Delete all associated slots when an account is deleted * Fix run_next_remove_address_slots * Copy initial accounts and slots * Fix find condition in run_next_remove_address_slots * Deep copy of accounts and slots * [WIP] Testing evm test suite * Fix most unit tests and fix revert_account_created * FIx linked list test and a bit of cleanup * [WIP] Debugging /stExample/basefeeExample_d0g0v0_Shanghai * Fix merge and add batch sizes to the benchmark * Fix test_only in zero_bin * Fix rlp pointers error * Remove panic * [WIP] Debugging InitCollisionParis_d2g0v0_Shanghai * [WIP] Debugging stCallCodes/callcallcodecallcode_011_SuicideEnd_d0g0v0_Shanghai * Fix remove_all_slots * Clean code * Fix account code initialize mpts * Apply comments and fix CI. * Improve remove_all_slots_loop * Fix stack comment * Misc, faster get_valid_slot_ptr * [WIP] Debugging erc20 * Remove counter update and cold_access * Fix log_opcode circuit sizes * Fix stack comment and remove ctr update * Fix preinitialization * Fix unit tests * Debugging stShift/shr01_d0g0v0_Shanghai * Fixing shiftSignedCombinations_d0g0v0_Shanghai * Remove counter assertions from linked_lists tests * Fix preinitialization and start cleanup * Fix test_process_receipt * Fix MPT insert tests * Add check in mpt_insert tests * Additional fixes * Pass preinitialized_segments when necessary * Fix all unit tests * Cleanup * More comments cleanup * Do not store memory content as vec * Prevent needless conversion * Remove needless copy * Remove needless checks * Use tuple_windows instead * Typo * Remove leftover * Remove unrelated changes * Fix clone_slot * Remove assert 0 from clone_slot * Fix next_node_ok_with_value * Apply comments and cleanup * Start * Do not recompute LLs * Remove unused preinit * Remove useless function * Rename for consistency * Cleanup * More cleanup * Minor * Lighten up initialization * Cleaner * Remove is_dummy * Remove dummy run * Fix next_node_ok_with_value and tiny cleanup * Simplify iterator * Tweak * Start addressing comments * Tweak * Mighty clippy * Revert num_procs * Remove unnecessary linked_lists methods and payload_ptr * Update .env file * Address comment, bring back txn hashes * Apply suggestion * Update sizes * Add explicit panic message --------- Co-authored-by: 4l0n50 <alonso.gon@gmail.com> Co-authored-by: Hamy Ratoanina <hamy.ratoanina@toposware.com> Co-authored-by: Alonso Gonzalez <agonzalez@Polygon-F6GJJLCQFL.local> Co-authored-by: Linda Guiga <lindaguiga3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Savings on average over
v0.5.0move from ~8%/10% fromlate_hash_continuationsbranch, PR #402, to ~15% / 16% with this branch.Also cleans up / refactors code a bit.
I would ideally move all the segmentation related stuff into a dedicated module, but leaving it for now as to not affect other PRs.