Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dockerhub access #486

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: dockerhub access #486

merged 1 commit into from
Aug 29, 2024

Conversation

atanmarko
Copy link
Member

No description provided.

@atanmarko atanmarko self-assigned this Aug 12, 2024
@vgnom vgnom added this to the System strengthening milestone Aug 14, 2024
@atanmarko atanmarko requested a review from 0xaatif August 28, 2024 21:39
@atanmarko atanmarko marked this pull request as ready for review August 28, 2024 21:39
0xaatif
0xaatif approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@0xaatif 0xaatif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@atanmarko atanmarko merged commit b219695 into develop Aug 29, 2024
16 checks passed
@atanmarko atanmarko deleted the fix/dockerhub branch August 29, 2024 07:41
@Nashtare
Copy link
Collaborator

It seems that these changes may be preventing PRs from external parties to succesfully go ✅ for the Jerigon CI jobs, cf 571 for instance.

@atanmarko
Copy link
Member Author

@Nashtare Execution of the CI for the external PR must be authorized by some of the project members (not just dockerhub related). When forked, they have to set their own project secrets to run CI on their fork. Anything else?

@0xaatif
Copy link
Contributor

0xaatif commented Aug 31, 2024

Is there a button I can't see to run the CI for #571 with our docker creds?

@Nashtare
Copy link
Collaborator

I can't seem to find a way to run it either. I tried re-running failed CI jobs but no change.

@atanmarko
Copy link
Member Author

atanmarko commented Aug 31, 2024 •
edited
Loading

I can't seem to find a way to run it either. I tried re-running failed CI jobs but no change.

Ok we need to consult devops and/or security team about how to handle this. Logging in to github container registry using CI secrets is passing in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xaatif 0xaatif 0xaatif approved these changes

@Nashtare Nashtare Nashtare approved these changes

@muursh muursh Awaiting requested review from muursh

Assignees

@atanmarko atanmarko

Labels
None yet
Projects
Zero EVM
Status: Done
Milestone
System strengthening
Development

Successfully merging this pull request may close these issues.
4 participants
@atanmarko @Nashtare @0xaatif @vgnom