Fix txn indexing in error message #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: trace_decoder
hratoanina
approved these changes
Aug 13, 2024
atanmarko
pushed a commit
that referenced
this pull request
Aug 14, 2024
0xaatif
pushed a commit
that referenced
this pull request
Aug 14, 2024
0xaatif
pushed a commit
that referenced
this pull request
Aug 14, 2024
|
Such a brutal bug, thanks for getting this! |
0xaatif
added a commit
that referenced
this pull request
Aug 15, 2024
* mark: 0xaatif/refactor-trace-decoder-decoding * refactor: remove inappropriate static methods * refactor: remove inappropriate method * refactor: remove TraceParsingErrorReason * refactor: remove LocatedError * refactor: remove EMPTY_ACCOUNT_BYTES_RLPED * refactor: remove update_val_if_some * refactor: impl Display for TrieType * wibble * refactor: inline TraceParsingResult * wibble * wibble: order * refactor: remove unused variable * wibble: inline TrieRoots etc * wibble * review: WithHash -> CustomFmt<T> * mark: 0xaatif/typed-backend3 * refactor: trace_decoder::typed_mpt::TriePath -> TrieKey * refactor: path: TriePath -> key: TrieKey * refactor: use typed_mpt in the backend * tweaks * refactor: remove allow(unused) * refactor: remove dead methods * bump * fix: do not force precompile address access in case of txn reversion (#488) * Fix precompile insertion in state trie * Reword * fix indexing in error message (#490) * refactor: more path -> key --------- Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were picking the already incremented
txn_idxin the error msg, which was causing discrepancies in error messages between expected and actual failing txn, cf #421 which caused unnecessary headache.