Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add leader command to flush cache #527

Merged
merged 5 commits into from
Aug 23, 2024
Merged

feat: add leader command to flush cache #527

merged 5 commits into from
Aug 23, 2024

Conversation

Nashtare
Copy link
Collaborator

I figured it may be nice to have a command to flush stored circuits on disk, in case they accumulate and start blowing up disk usage, or even in case of discrepancies for cryptographers working on the constraints (as we only do a version-check through the Kernel code hash).

➜  zk_evm git:(clean_cache) ✗ ./target/release/leader --help
zero-bin leader config

Usage: leader [OPTIONS] <COMMAND>

Commands:
  clean  Deletes all the previously cached circuits
  stdio  Reads input from stdin and writes output to stdout
  rpc    Reads input from a node rpc and writes output to stdout
  http   Reads input from HTTP and writes output to a directory
  help   Print this message or the help of the given subcommand(s)

@Nashtare Nashtare added this to the x Misc. milestone Aug 21, 2024
@Nashtare Nashtare self-assigned this Aug 21, 2024
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Aug 21, 2024
@0xaatif
Copy link
Contributor

0xaatif commented Aug 22, 2024

LGTM, I think this moves is away from the #447 direction though

@Nashtare
Copy link
Collaborator Author

Nashtare commented Aug 22, 2024

LGTM, I think this moves is away from the #447 direction though

I don't disagree with this, although I strongly feel we need a mechanism for cache flushing, ideally something better than just manually doing rm -rf. Every time we re-generate, we store ~50GB of circuits on disk.

@Nashtare Nashtare merged commit 6c455ec into develop Aug 23, 2024
15 checks passed
@Nashtare Nashtare deleted the clean_cache branch August 23, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants