Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: trace decoder backend #583

Merged
merged 61 commits into from
Sep 12, 2024
Merged

refactor: trace decoder backend #583

merged 61 commits into from
Sep 12, 2024

Conversation

0xaatif
Copy link
Contributor

@0xaatif 0xaatif commented Sep 2, 2024 •
edited
Loading

  • Refactor the code to be a straight loop
  • Make the core impl StateTrie agnostic
  • Document the crate

@github-actions github-actions bot added crate: trace_decoder Anything related to the trace_decoder crate. crate: evm_arithmetization Anything related to the evm_arithmetization crate. labels Sep 2, 2024
@0xaatif 0xaatif force-pushed the 0xaatif/trace-decoder-backend-rewrite4 branch from 2d2f2e8 to 844971f Compare September 2, 2024 13:49
0xaatif added 16 commits September 2, 2024 17:38
@0xaatif
refactor: trace_decoder tests do not expect json array in files
0407031
@0xaatif
chore: trace_decoder test inputs are no longer arrays
408273a
@0xaatif
feat: trace_decoder/examples/dump.rs
c83f223
@0xaatif
Revert "chore: trace_decoder test inputs are no longer arrays"
6771d0c 
This reverts commit 408273a.
@0xaatif
Revert "refactor: trace_decoder tests do not expect json array in files"
2a6d843 
This reverts commit 0407031.
@0xaatif
refactor: dump accept multi
322def0
@0xaatif
add --quiet
fd2e90d
@0xaatif
fix: remove unaccessed storage tries
81907a9
@0xaatif
test: ab
e05f3d0
@0xaatif
test: break out common
4511b80
@0xaatif
test: a/b
3546b42
@0xaatif
fix: imp::batch
d11a365
@0xaatif
fix: storage shenanigans
69ed607
@0xaatif
refactor(ci): separate build for tests
69249b0
@0xaatif
refactor(ci): refactor conditions
42b5d68
@0xaatif
Merge remote-tracking branch 'origin/develop' into 0xaatif/trace-deco…
ace2af1 
…der-backend-rewrite4
@Nashtare Nashtare added this to the System strengthening milestone Sep 4, 2024
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Sep 4, 2024
@0xaatif 0xaatif mentioned this pull request Sep 6, 2024
Closed
@0xaatif 0xaatif mentioned this pull request Sep 9, 2024
Open
@0xaatif 0xaatif requested a review from Nashtare September 9, 2024 12:33
@0xaatif 0xaatif mentioned this pull request Sep 9, 2024
Draft
@Nashtare
Copy link
Collaborator

Nashtare commented Sep 10, 2024 •
edited
Loading

On an unrelated note, I benchmarked the decoder processing time against develop and even if this isn't the main concern of this module, it's nice to see a 50% reduction in processing time 🙂

@github-actions github-actions bot added the ci label Sep 11, 2024
@0xaatif 0xaatif force-pushed the 0xaatif/trace-decoder-backend-rewrite4 branch from 06aefa5 to 9e048b9 Compare September 11, 2024 11:00
@0xaatif 0xaatif force-pushed the 0xaatif/trace-decoder-backend-rewrite4 branch 2 times, most recently from f56b00d to af9251a Compare September 11, 2024 11:03
Nashtare
Nashtare approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly good with this.
Tested against a significant portion of the test suite without any issues.

@0xaatif 0xaatif merged commit 5bb3a6a into develop Sep 12, 2024
18 checks passed
@0xaatif 0xaatif deleted the 0xaatif/trace-decoder-backend-rewrite4 branch September 12, 2024 16:42
@Nashtare Nashtare mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanmarko atanmarko atanmarko approved these changes

@Nashtare Nashtare Nashtare approved these changes

@muursh muursh Awaiting requested review from muursh

@LindaGuiga LindaGuiga Awaiting requested review from LindaGuiga LindaGuiga is a code owner

Assignees

@0xaatif 0xaatif

Labels
ci crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: trace_decoder Anything related to the trace_decoder crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
Type 2 - CDK Erigon (Q4 2024)
Development

Successfully merging this pull request may close these issues.
3 participants
@0xaatif @Nashtare @atanmarko