Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Do not perform sanity check on test_only runs #635

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Nashtare
Copy link
Collaborator

We do not perform anything related to the aggregation / block layers in test_only mode, but the sanity check on the leader side still forces us to pass expectedly correct values for checkpoint-block-number and/or previous-proof which is cumbersome for testing only.

@Nashtare Nashtare added this to the x Misc. milestone Sep 18, 2024
@Nashtare Nashtare self-assigned this Sep 18, 2024
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Sep 18, 2024
@Nashtare Nashtare merged commit e13af35 into develop Sep 20, 2024
17 checks passed
@Nashtare Nashtare deleted the misc/no_check_test_only branch September 20, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants