-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the root circuit to conditionally verify Keccak proofs #652
Conversation
This reverts commit f63363b.
…verify_in_root_circuit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sai, just a couple nits for readability
builder.add_gate_to_gate_set(GateRef::new(ConstantGate::new( | ||
builder.config.num_constants, | ||
))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe unrelated, but if we add this to the common recursion gates, I think we may be able to remove this from the root circuit definition?
builder.add_gate(
ConstantGate::new(inner_common_data[0].config.num_constants),
vec![],
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may get trouble without it in the recursion circuits after it. Since in conditional verifying, we need a dummy circuit. But the dummy circuit will generate a constant gate while this one (root circuit) will not generate it.
Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
Thanks for reviewing. I just tested the root circuit size changes. Degree after blinding & padding: 65536 |
04aaffc
to
a23eaf0
Compare
75f6452
to
baba9da
Compare
…verify_in_root_circuit
…verify_in_root_circuit
…verify_in_root_circuit
Implements the new root circuits in #620
This PR has been tested in combination with #657 and #648
Please review the circuit carefully, as it may impact the security of the system.
The gate number increased by 3083 when using the table ranges in
.env
.Circuit size before this PR:
After this PR: