perf: Remove some binary ops & make KERNEL init section free of logic operations
#658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
hratoanina
reviewed
Sep 25, 2024
muursh
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the 3 logic operations initially required by the segmentation mechanism (at the cost of
3 extra1 extra CPU cycle per segment), to allow for full removal ofLogicStarktable when possible, following @sai-deng's approach on the Keccak table.Also did a pass on binary ops in the Kernel, as most of them could be expressed differently at no extra cost, to try make it even more likely to happen (
simple_transfergoes from 1112 to 173 binary ops).