Optimize code by using De Morgan laws #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einar-polygon
requested review from
wborgeaud,
muursh,
Nashtare and
LindaGuiga
as code owners
github-actions
bot
added
the
crate: evm_arithmetization
Nashtare
reviewed
Sep 29, 2024
There was a problem hiding this comment.
Thanks Einar! Unfortunately it is not improving the current KERNEL code (most likely because this would only possibly apply to the hash precompiles, where we already improved the binary ops combinations), but good to have nonetheless for the future!
I've left a light comment inline to expand the covering further
Nashtare
approved these changes
Oct 1, 2024
| @@ -157,6 +159,65 @@ fn remove_ignored_values(code: &mut Vec<Item>) { | |||
| }); | |||
| } | |||
|
|
|||
| /// Helper predicate for the De Morgan rules. | |||
| fn is_push_or_dup(op: &Item) -> bool { | |||
There was a problem hiding this comment.
nit: we could use this new helper above in remove_ignored_values, but the pattern matching may be clearer, so non-blocking.
There was a problem hiding this comment.
Done.
It is not worse, but I don't know if it is better.
github-actions
bot
added
crate: trace_decoder
einar-polygon
force-pushed
the
einar/demorgan
branch
from
9c6751d to
aec0771
Compare
github-actions
bot
removed
crate: trace_decoder
0xaatif
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.