Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use install-action instead of cargo-binstall #679

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

0xaatif
Copy link
Contributor

@0xaatif 0xaatif commented Oct 1, 2024

I was seeing this weird behaviour:

Run cargo binstall taplo-cli
 INFO resolve: Resolving package: 'taplo-cli'
 INFO resolve: taplo-cli v0.9.3 is already installed, use --force to override
 INFO Done in [15]
Run taplo fmt --check
/home/runner/work/_temp/54a69868-69ab-442e-9fca-6020599020c1.sh: line 1: taplo: command not found

In https://github.com/0xPolygonZero/zk_evm/actions/runs/11123847101/job/30908151308#step:4:16 (an empty commit)

Not sure what's going on, but let's use someone else's github action instead

@0xaatif 0xaatif changed the title try: broken ci? fix(ci): weird behaviour using cargo-binstall Oct 1, 2024
@0xaatif 0xaatif changed the title fix(ci): weird behaviour using cargo-binstall fix(ci): use install-action instead of cargo-binstall Oct 1, 2024
@0xaatif 0xaatif marked this pull request as ready for review October 1, 2024 11:08
@0xaatif
Copy link
Contributor Author

0xaatif commented Oct 1, 2024

security_audit is a required check, but only runs if I've change any Cargo.tomls - I think that's a CI bug @Nashtare, and this will need manual merge

Has this changed recently?

@muursh
Copy link
Contributor

muursh commented Oct 1, 2024

security_audit is a required check, but only runs if I've change any Cargo.tomls - I think that's a CI bug @Nashtare, and this will need manual merge

Has this changed recently?

Removed as a req. for now.

@0xaatif 0xaatif merged commit 07bdbd0 into develop Oct 1, 2024
20 checks passed
@0xaatif 0xaatif deleted the 0xaatif/wat branch October 1, 2024 11:53
@0xaatif 0xaatif mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants