Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize zkVM Proving by Skipping Unused Keccak Tables #690

Merged
merged 122 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
122 commits
Select commit Hold shift + click to select a range
662c8db
refactoring
sai-deng Sep 21, 2024
d82b1a8
fix clippy
sai-deng Sep 21, 2024
4498870
fix clippy
sai-deng Sep 21, 2024
b14417f
wip
sai-deng Sep 22, 2024
eabcf5e
wip
sai-deng Sep 22, 2024
2ad3857
Merge branch 'develop' into sai/skip_table_in_root_circuit
sai-deng Sep 23, 2024
2b2e737
wip
sai-deng Sep 23, 2024
f63363b
cleanup
sai-deng Sep 23, 2024
cc9d41b
prove one segment
sai-deng Sep 23, 2024
fe88819
polish the code
sai-deng Sep 23, 2024
7ff2fb1
cleanup
sai-deng Sep 23, 2024
6ce3cbe
Revert "cleanup"
sai-deng Sep 23, 2024
8c940b0
add [ignore]
sai-deng Sep 23, 2024
d6af500
add challenger state check
sai-deng Sep 23, 2024
f5deedb
add more checks
sai-deng Sep 23, 2024
e39894a
cleanup
sai-deng Sep 23, 2024
948d742
add empty keccak tables bool
sai-deng Sep 24, 2024
49bb96b
enable no keccak recursion
sai-deng Sep 24, 2024
bbba820
refactor
sai-deng Sep 24, 2024
8c4a362
fix tests
sai-deng Sep 24, 2024
5cdb37d
rename
sai-deng Sep 24, 2024
2f0129e
fix pis
sai-deng Sep 24, 2024
36ace10
fix
sai-deng Sep 25, 2024
5b7f818
resolve conflicts
sai-deng Sep 25, 2024
56deaa3
done
sai-deng Sep 25, 2024
7a3fe08
polish the comments
sai-deng Sep 25, 2024
cfc6f24
Merge branch 'sai/conditionally_verify_in_root_circuit' into sai/enab…
sai-deng Sep 25, 2024
4d288f8
fix ci
sai-deng Sep 25, 2024
e6bed69
add comments
sai-deng Sep 25, 2024
0bd1448
fix ci
sai-deng Sep 25, 2024
3800986
update tests
sai-deng Sep 25, 2024
674485e
Merge branch 'sai/skip_table_in_root_circuit' into sai/conditionally_…
sai-deng Sep 25, 2024
daaabb6
Merge branch 'sai/conditionally_verify_in_root_circuit' into sai/enab…
sai-deng Sep 25, 2024
91dbeaa
fix ci
sai-deng Sep 25, 2024
bb79080
fix ci
sai-deng Sep 25, 2024
ed9637d
Merge branch 'develop' into sai/skip_table_in_root_circuit
sai-deng Sep 25, 2024
fd55d1a
fix ci
sai-deng Sep 25, 2024
6b27552
Merge branch 'sai/skip_table_in_root_circuit' into sai/conditionally_…
sai-deng Sep 25, 2024
ab2ec50
Merge branch 'sai/conditionally_verify_in_root_circuit' into sai/enab…
sai-deng Sep 25, 2024
4de4c64
empty payload and no keccak op check
sai-deng Sep 26, 2024
e34c59a
refactor
sai-deng Sep 26, 2024
be887e6
Update evm_arithmetization/src/fixed_recursive_verifier.rs
sai-deng Sep 30, 2024
d2ca0cc
Update evm_arithmetization/src/fixed_recursive_verifier.rs
sai-deng Sep 30, 2024
ce88ef8
empty payload and no keccak op check
sai-deng Sep 26, 2024
a23eaf0
fmt
sai-deng Sep 30, 2024
7d72eb9
Merge branch 'develop' into sai/skip_table_in_root_circuit
sai-deng Sep 30, 2024
baba9da
merge
sai-deng Sep 30, 2024
ec64af9
Merge branch 'sai/conditionally_verify_in_root_circuit' into sai/enab…
sai-deng Sep 30, 2024
04f51d5
wip
sai-deng Oct 1, 2024
ac41fa4
Merge branch 'develop' into sai/skip_table_in_root_circuit
sai-deng Oct 1, 2024
f24d028
Merge branch 'sai/skip_table_in_root_circuit' into sai/conditionally_…
sai-deng Oct 1, 2024
58f37e8
Merge branch 'sai/conditionally_verify_in_root_circuit' into sai/enab…
sai-deng Oct 1, 2024
031f95f
Merge branch 'sai/enable_keccak_optional_proving' into sai/refactor_o…
sai-deng Oct 1, 2024
c822a70
fix test
sai-deng Oct 1, 2024
2886fd8
Merge branch 'sai/skip_table_in_root_circuit' into sai/conditionally_…
sai-deng Oct 1, 2024
1540078
Merge branch 'sai/conditionally_verify_in_root_circuit' into sai/enab…
sai-deng Oct 1, 2024
12c61a8
fix ci with "cdk_erigon"
sai-deng Oct 1, 2024
447cfb9
fix ci error with "cdk_erigon"
sai-deng Oct 1, 2024
5f935c2
Merge branch 'sai/skip_table_in_root_circuit' into sai/conditionally_…
sai-deng Oct 1, 2024
42afc90
Merge branch 'sai/conditionally_verify_in_root_circuit' into sai/enab…
sai-deng Oct 1, 2024
54fce4a
Merge branch 'sai/enable_keccak_optional_proving' into sai/refactor_o…
sai-deng Oct 1, 2024
ac5a87a
wip
sai-deng Oct 2, 2024
40867c0
Merge branch 'develop' into sai/conditionally_verify_in_root_circuit
sai-deng Oct 2, 2024
e7ab9eb
Merge branch 'sai/conditionally_verify_in_root_circuit' into sai/enab…
sai-deng Oct 2, 2024
09a1a4a
enable test
sai-deng Oct 2, 2024
4a69e8a
Update evm_arithmetization/src/fixed_recursive_verifier.rs
sai-deng Oct 2, 2024
81d3681
address comments
sai-deng Oct 2, 2024
79aeb72
sync changes into get_challenges
sai-deng Oct 2, 2024
732020d
wip
sai-deng Oct 2, 2024
5a66c69
merge changes
sai-deng Oct 2, 2024
9f8ec9e
fix
sai-deng Oct 2, 2024
503085b
fix
sai-deng Oct 2, 2024
ba32c31
merge changes
sai-deng Oct 2, 2024
09a3f7c
wip
sai-deng Oct 3, 2024
a36c5f7
fix tests
sai-deng Oct 3, 2024
835df60
sync updates
sai-deng Oct 3, 2024
fb59562
wip
sai-deng Oct 3, 2024
640bae1
fix
sai-deng Oct 3, 2024
faf80f1
Merge branch 'sai/enable_keccak_optional_proving' into sai/refactor_o…
sai-deng Oct 3, 2024
3eadb91
done
sai-deng Oct 3, 2024
d04d0ff
fix clippy
sai-deng Oct 3, 2024
87e9102
fix build
sai-deng Oct 3, 2024
86eccaf
change default degree
sai-deng Oct 4, 2024
e1a5bb0
wip
sai-deng Oct 4, 2024
b89359e
refactor get ctl_vars from proof
sai-deng Oct 5, 2024
179e6bf
wip
sai-deng Oct 5, 2024
c022343
fix tests
sai-deng Oct 5, 2024
051702d
address comments
sai-deng Oct 6, 2024
68e4575
merge
sai-deng Oct 6, 2024
246afda
longer zero bin build timeout
sai-deng Oct 7, 2024
eca94e0
temporally force run test zero bin ci
sai-deng Oct 7, 2024
fc12691
temporally disable pr checking
sai-deng Oct 7, 2024
36af7e6
revert ci changes
sai-deng Oct 7, 2024
6a83607
merge develop
sai-deng Oct 7, 2024
13575f6
fix build after merge
sai-deng Oct 7, 2024
782eeb1
do not use remove
sai-deng Oct 7, 2024
6766fdd
longer zero bin timeout
sai-deng Oct 7, 2024
082cc89
fix build
sai-deng Oct 7, 2024
ecb9943
fix clippy
sai-deng Oct 7, 2024
78fce60
revert zero bin timeout
sai-deng Oct 7, 2024
937925c
Merge branch 'develop' into sai/refactor_optional_table_proving
sai-deng Oct 7, 2024
1a673e2
address comments
sai-deng Oct 8, 2024
8660749
address comments
sai-deng Oct 8, 2024
46c0684
clippy
sai-deng Oct 8, 2024
a4715b7
fix build
sai-deng Oct 8, 2024
a260fba
merge tests
sai-deng Oct 9, 2024
27590f8
clippy
sai-deng Oct 9, 2024
3dd6d61
build
sai-deng Oct 10, 2024
0aa31ed
polish code
sai-deng Oct 10, 2024
96f499b
refactor
sai-deng Oct 10, 2024
8cec513
wip
sai-deng Oct 11, 2024
20b567b
build
sai-deng Oct 11, 2024
911bd4b
fix
sai-deng Oct 11, 2024
9f2283e
try to fix
sai-deng Oct 11, 2024
a7be2b9
wip
sai-deng Oct 11, 2024
9021124
done
sai-deng Oct 11, 2024
7374f05
fix
sai-deng Oct 11, 2024
8bd679e
merge develop
sai-deng Oct 11, 2024
557d221
fix tests
sai-deng Oct 11, 2024
564b950
address comments
sai-deng Oct 15, 2024
c8f03fc
fix a bug with index_verifier_data
sai-deng Oct 15, 2024
3581d50
Merge branch 'develop' into sai/refactor_optional_table_proving
sai-deng Oct 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,10 @@ zk_evm_proc_macro = { path = "proc_macro", version = "0.1.0" }
zero = { path = "zero", default-features = false }

# plonky2-related dependencies
plonky2 = { git = "https://github.com/0xPolygonZero/plonky2.git", rev = "dc77c77f2b06500e16ad4d7f1c2b057903602eed" }
plonky2 = { git = "https://github.com/0xPolygonZero/plonky2.git", rev = "8463effe0dd1472a52906cd12ffb047885db42ee" }
plonky2_maybe_rayon = "0.2.0"
plonky2_util = { git = "https://github.com/0xPolygonZero/plonky2.git", rev = "dc77c77f2b06500e16ad4d7f1c2b057903602eed" }
starky = { git = "https://github.com/0xPolygonZero/plonky2.git", rev = "dc77c77f2b06500e16ad4d7f1c2b057903602eed" }
plonky2_util = { git = "https://github.com/0xPolygonZero/plonky2.git", rev = "8463effe0dd1472a52906cd12ffb047885db42ee" }
starky = { git = "https://github.com/0xPolygonZero/plonky2.git", rev = "8463effe0dd1472a52906cd12ffb047885db42ee" }

[workspace.lints.clippy]
too_long_first_doc_paragraph = "allow"
Loading
Loading