Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unused MemAfter table #738

Merged
merged 1 commit into from
Oct 20, 2024
Merged

fix: unused MemAfter table #738

merged 1 commit into from
Oct 20, 2024

Conversation

sai-deng
Copy link
Contributor

@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Oct 19, 2024
@sai-deng sai-deng marked this pull request as ready for review October 19, 2024 22:43
Nashtare
Nashtare approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@Nashtare Nashtare merged commit f8c5f9c into develop Oct 20, 2024
20 checks passed
@Nashtare Nashtare deleted the sai/tmp_fix_mem_after branch October 20, 2024 00:03
LindaGuiga added a commit that referenced this pull request Oct 23, 2024
@LindaGuiga
Revert "fix (#738)"
2d66aa7 
This reverts commit f8c5f9c.
@LindaGuiga LindaGuiga mentioned this pull request Oct 24, 2024
Merged
LindaGuiga added a commit that referenced this pull request Nov 1, 2024
@LindaGuiga
Reapply "fix (#738)"
e9a0cf0 
This reverts commit 2d66aa7.
Nashtare added a commit that referenced this pull request Nov 5, 2024
@LindaGuiga @Nashtare
Prune child context in create and call faults (#747)
51cf498 
* Prune child context after create failure

* call_insufficient_balance fix

* Fix create failures and drain_all_but_one_64th_gas

* Revert "fix (#738)"

This reverts commit f8c5f9c.

* Remove unnecessary changes

* Reapply "fix (#738)"

This reverts commit 2d66aa7.

* Add warning when the last MemAfter is not empty

* Apply comment

* Apply comment

---------

Co-authored-by: Robin Salen <salenrobin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashtare Nashtare Nashtare approved these changes

@wborgeaud wborgeaud Awaiting requested review from wborgeaud wborgeaud is a code owner

@muursh muursh Awaiting requested review from muursh

@LindaGuiga LindaGuiga Awaiting requested review from LindaGuiga LindaGuiga is a code owner

Assignees
No one assigned
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Zero EVM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sai-deng @Nashtare