ci: warn on outdated top level dependencies #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xaatif
requested review from
atanmarko,
Nashtare and
paulgoleary
as code owners
atanmarko
approved these changes
Oct 29, 2024
|
Not sure if we care about every bug fix version change of every dependency, is it too aggressive to warn about that as outdated dependency? |
It's a fair concern. I think we do care about patch version bumps because they could be security fixes (depending on the package policy) |
atanmarko
reviewed
Oct 29, 2024
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Nit: you could probably use @v4 here.
There was a problem hiding this comment.
Let's update all of these at once: #759
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: ./.github/actions/rust | ||
| - uses: taiki-e/install-action@v2 |
There was a problem hiding this comment.
Nit: I am starting to feel just slightly uncomfortable about number of external GithubAction dependencies we are including in our CI.
LindaGuiga
approved these changes
Oct 30, 2024
praetoriansentry
approved these changes
Oct 30, 2024
Nashtare
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #746
Need to transform
cargo-outdated's output to github's warning format.Didn't fancy coming up with some jq to do it - let's use a real programming language :)
This isn't strictly "secure", as we only lint dependencies we ourselves specify in
Cargo.toml, not our transitive deps.But that's a huge list and we should sort that later.
We should probably move our other monster bash scripts to rust anyway.
Works a treat:
