Move World trait and related into evm_arithmetization crate
#783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
requested review from
0xaatif,
wborgeaud,
LindaGuiga and
paulgoleary
as code owners
github-actions
bot
added
crate: trace_decoder
When I had done the change, I just thought it would make more sense to have world.rs and the related methods in the same crate. But I'm not at all opposed to only moving |
Nashtare
added a commit
that referenced
this pull request
Nov 7, 2024
* Add Hasher trait to World * Use dedicated code hasher in processing * Move `World` trait and related into `evm_arithmetization` crate (#783) * Move world into evm_arithmetization * Rustdoc * Apply suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functionality change, just moving things around for type2 integration.
@LindaGuiga Note that I haven't moved all the modules into
evm_arithmetizationas you had done initially, not sure whether this was for simplicity or because I overlooked something.