feat: Add env support to all leader prog args #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All leader program args now have a corresponding env variable that can also set it. This should make it easier to deploy in certain settings. Issue: #760
BGluth
changed the title
github-actions
bot
added
the
crate: zero_bin
atanmarko
reviewed
Nov 7, 2024
BGluth
added a commit
to 0xPolygonZero/paladin
that referenced
this pull request
Nov 7, 2024
- The `zk_evm` leader bin just had env support added for it's prog args. However, some of its args are defined in `paladin`, so we needed to create a separate PR for this repo to add env support for the `paladin` specific prog args. - See also PR [#786](0xPolygonZero/zk_evm#786) in `zk_evm`.
BGluth
added a commit
to 0xPolygonZero/paladin
that referenced
this pull request
Nov 7, 2024
- The `zk_evm` leader bin just had env support added for it's prog args. However, some of its args are defined in `paladin`, so we needed to create a separate PR for this repo to add env support for the `paladin` specific prog args. - See also PR [#786](0xPolygonZero/zk_evm#786) in `zk_evm`.
BGluth
added a commit
to 0xPolygonZero/paladin
that referenced
this pull request
Nov 7, 2024
- The `zk_evm` leader bin just had env support added for it's prog args. However, some of its args are defined in `paladin`, so we needed to create a separate PR for this repo to add env support for the `paladin` specific prog args. - See also PR [#786](0xPolygonZero/zk_evm#786) in `zk_evm`.
atanmarko
reviewed
Nov 7, 2024
temaniarpit27
approved these changes
Nov 8, 2024
atanmarko
approved these changes
Nov 8, 2024
atanmarko
pushed a commit
to 0xPolygonZero/paladin
that referenced
this pull request
Nov 8, 2024
* feat: Added env support for prog args - The `zk_evm` leader bin just had env support added for it's prog args. However, some of its args are defined in `paladin`, so we needed to create a separate PR for this repo to add env support for the `paladin` specific prog args. - See also PR [#786](0xPolygonZero/zk_evm#786) in `zk_evm`. * Also included new clippy lint & dep downbump - Very unsure why the downbump is occuring when building on the latest compiler...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All leader program args now have a corresponding env variable that can also set it. This should make it easier to deploy in certain settings.
There's a bit of a minor DRY violation with repeating
ZERO_BIN_for each of the env args, but I don't think there's too much that we can do to get around this even if we consider proc macros. Let me know if anyone has any suggestions, but yeah otherwise I think this is fine.Finally also note that some of the args are defined in
paladin, so another PR will be needed to be created there to also add inenvsupport.Issue: #760