Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Fix function calling #426

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Fix function calling #426

merged 2 commits into from
Mar 27, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Mar 27, 2023 •
edited
Loading

Usage related changes

Development related changes

  • Improve testing
  • Improve typing in validate_request
  • Replace request.data with request.get_data() in feeder_gateway (works better?)

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@FabijanC FabijanC marked this pull request as ready for review March 27, 2023 11:44
@FabijanC FabijanC requested a review from mikiw March 27, 2023 11:44
mikiw
mikiw suggested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@mikiw mikiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content_type problem

@FabijanC FabijanC merged commit 27cd371 into master Mar 27, 2023
@FabijanC FabijanC deleted the fix-call branch March 27, 2023 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikiw mikiw mikiw requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

call_contract internal server error (0.5.0a0)
2 participants
@FabijanC @mikiw