Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicitly calculate maxFee #164

Closed
FabijanC opened this issue Jul 14, 2022 · 0 comments · Fixed by #199
Closed

Implicitly calculate maxFee #164

FabijanC opened this issue Jul 14, 2022 · 0 comments · Fixed by #199
Assignees
@Nathan-SL
Labels
breaking A breaking change enhancement New feature or request

Comments

@FabijanC
Copy link
Collaborator

Currently users have to manually run account.estimateFee before doing account.invoke and explicitly set maxFee as an option of the invoke. Ideally this would be done implicitly, by internally calling fee estimation, and multiplying it with a factor (see which factor others use).

This would be a breaking change since currently the maxFee is implicitly 0 by default.
@FabijanC FabijanC added the enhancement New feature or request label Jul 14, 2022
@FabijanC FabijanC moved this to 🆕 New in starknet-hardhat-plugin Jul 14, 2022
@FabijanC FabijanC moved this from 🆕 New to 📋 Backlog in starknet-hardhat-plugin Jul 14, 2022
@Nathan-SL Nathan-SL added the breaking A breaking change label Aug 25, 2022
@Nathan-SL Nathan-SL mentioned this issue Sep 1, 2022
Merged
11 tasks
@FabijanC FabijanC mentioned this issue Sep 23, 2022
Closed
@FabijanC FabijanC mentioned this issue Nov 29, 2022
Merged
10 tasks
Repository owner moved this from 📋 Backlog to ✅ Done in starknet-hardhat-plugin Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nathan-SL Nathan-SL

Labels
breaking A breaking change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce some breaking changes for 0.7.0 0xSpaceShard/starknet-hardhat-plugin
2 participants
@FabijanC @Nathan-SL