Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate estimateFee Implicitly #206

Merged
merged 6 commits into from
Sep 9, 2022
Merged

Calculate estimateFee Implicitly #206

merged 6 commits into from
Sep 9, 2022

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Sep 1, 2022 •
edited
Loading

Usage related changes

Development related changes

  • NA

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.sh)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:Update test for invoke starknet-hardhat-example#79
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@Nathan-SL Nathan-SL changed the title Calculate MaxFee Implicit Calculate estimateFee Implicitly Sep 1, 2022
@Nathan-SL Nathan-SL requested a review from FabijanC September 2, 2022 07:51
FabijanC
FabijanC requested changes Sep 8, 2022
View reviewed changes
src/account.ts Outdated Show resolved Hide resolved
src/account.ts Outdated Show resolved Hide resolved
src/account.ts Outdated Show resolved Hide resolved
scripts/test.sh Outdated Show resolved Hide resolved
FabijanC
FabijanC requested changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the docs?

src/account.ts Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit af7b7fb into release-0.7.0 Sep 9, 2022
@FabijanC FabijanC deleted the implicit-maxfee-on-invoke branch September 9, 2022 15:29
FabijanC added a commit that referenced this pull request Dec 2, 2022
@FabijanC @Nathan-SL
Introduce some breaking changes for 0.7.0 (#199) [skip ci]
ee977a8 
* Make account-contract a flag in starknet-verify (#198)

* Calculate estimateFee Implicitly (#206)

* Change return type of function decodeEvents (#205)

Co-authored-by: Nathan <102951164+Nathan-SL@users.noreply.github.com>
Co-authored-by: Nathan-SL <nl@shardlabs.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nathan-SL @FabijanC