Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with ascendant calculation utility. #6

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

BuffMcBigHuge
Copy link
Contributor

According to https://en.wikipedia.org/wiki/Ascendant, 180 degrees must be added to the ascendant degree if the calculated ascendant degree is less than 180 degrees.

Tested with the following parameters and validated with Astro.com.

Lat: 40.65871
Lng: -73.64124
Date: March 25th, 1989

Correct Ascendant Zodiac: Aquarius

Screen Shot 2021-01-14 at 7 35 53 PM

Copy link

@JAlbertoGonzalez JAlbertoGonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is absolutely neccesary to get the correct ascendant degrees. Without this fix, some dates leads to unexpected results.

@0xStarcat 0xStarcat merged commit 6f87f72 into 0xStarcat:master Feb 11, 2021
@0xStarcat
Copy link
Owner

0xStarcat commented Feb 11, 2021

@BuffMcBigHuge thanks for the fix and PR!

@JAlbertoGonzalez thanks for reviewing and approving

sorry for missing this PR - merged and will tag a new release from master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants