Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix notehead bounding box #1544

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix notehead bounding box #1544

merged 1 commit into from
Mar 29, 2023

Conversation

rvilarl
Copy link
Collaborator

@rvilarl rvilarl commented Mar 23, 2023

fixes #556

  • noteheads of stavenotes are not preformatted.
  • stavenot reset should use setstave to recalculate properly.

@rvilarl
Copy link
Collaborator Author

rvilarl commented Mar 23, 2023

Test changed to use also StaveNotes, this one wouldfail without this PR (current first)
pptr-NoteHead Bounding_Boxes Bravura svg_current
pptr-NoteHead Bounding_Boxes Bravura svg_reference

Differences due to StaveNote change (current first)
pptr-Auto_Beaming Break_Beams_on_Middle_Rests_Only Bravura svg_current
pptr-Auto_Beaming Break_Beams_on_Middle_Rests_Only Bravura svg_reference
pptr-Auto_Beaming Beam_Across_All_Rests_with_Stemlets Bravura svg_current
pptr-Auto_Beaming Beam_Across_All_Rests_with_Stemlets Bravura svg_reference
pptr-Auto_Beaming Beam_Across_All_Rests Bravura svg_current
pptr-Auto_Beaming Beam_Across_All_Rests Bravura svg_reference
pptr-Tuplet Complex_Tuplet Bravura svg_current
pptr-Tuplet Complex_Tuplet Bravura svg_reference

@sschmidTU
Copy link
Contributor

All the comparison images look the exact same to me, is the difference so small?
Though generally it's always nice to fix the bounding boxes, we also noticed some inaccuracies there in OSMD.

@rvilarl
Copy link
Collaborator Author

rvilarl commented Mar 23, 2023

@sschmidTU The first test, which was modified to use StaveNotes rather than NoteHeads crashes without the modification.
The last beam with rests in the middle is lower.
The 3 on the last image is very slightly lower.

@rvilarl
Copy link
Collaborator Author

rvilarl commented Mar 23, 2023

By the way the bounding box calculation is not accurate but I did not go into that.

@rvilarl rvilarl merged commit f45f672 into 0xfe:master Mar 29, 2023
@rvilarl rvilarl deleted the fix/556 branch May 7, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't obtain Notehead Bounding Box
2 participants