Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clef annotations size refactor #1552

Merged
merged 1 commit into from
Apr 8, 2023
Merged

clef annotations size refactor #1552

merged 1 commit into from
Apr 8, 2023

Conversation

rvilarl
Copy link
Collaborator

@rvilarl rvilarl commented Apr 6, 2023

Four more points removed from the metrics. I have also used the same scale related to the size of the clef.

@rvilarl
Copy link
Collaborator Author

rvilarl commented Apr 6, 2023

current first

pptr-canvas_Clef Clef_Change_Test Bravura_current
pptr-canvas_Clef Clef_Change_Test Bravura_reference

pptr-canvas_Clef Clef_Test Bravura_current
pptr-canvas_Clef Clef_Test Bravura_reference

@rvilarl
Copy link
Collaborator Author

rvilarl commented Apr 8, 2023

This makes the default clef annotation a little bigger but making the constant smaller makes the annotation, in my oppinion too small for change clefs. Merging, the code chage is minor and the constant can be adjusted on the visual review.

@rvilarl rvilarl merged commit 551fe42 into 0xfe:master Apr 8, 2023
@rvilarl rvilarl deleted the point/clefAnnotations branch May 7, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant