Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QUnit #1562

Merged
merged 4 commits into from
May 2, 2023
Merged

Update QUnit #1562

merged 4 commits into from
May 2, 2023

Conversation

rvilarl
Copy link
Collaborator

@rvilarl rvilarl commented Apr 28, 2023 •
edited
Loading

#fixes 1551

The following files are marked as different (bravura), they must be minor, I do not see them. Ready to review

pptr-TabSlide Slide_Up Bravura svg_current
pptr-TabSlide Slide_Up Bravura svg_reference
pptr-TabSlide Slide_Down Bravura svg_current
pptr-TabSlide Slide_Down Bravura svg_reference
pptr-TabSlide Simple_TabSlide Bravura svg_current
pptr-TabSlide Simple_TabSlide Bravura svg_reference
pptr-TabNote TabNote_Stems_with_Dots Bravura svg_current
pptr-TabNote TabNote_Stems_with_Dots Bravura svg_reference
pptr-TabNote TabNote_Stems_Up_Through_Stave Bravura svg_current
pptr-TabNote TabNote_Stems_Up_Through_Stave Bravura svg_reference
pptr-TabNote TabNote_Stems_Up Bravura svg_current
pptr-TabNote TabNote_Stems_Up Bravura svg_reference
pptr-TabNote TabNote_Stems_Down_Through_Stave Bravura svg_current
pptr-TabNote TabNote_Stems_Down_Through_Stave Bravura svg_reference
pptr-TabNote TabNote_Stems_Down Bravura svg_current
pptr-TabNote TabNote_Stems_Down Bravura svg_reference
pptr-TabNote TabNote_Draw Bravura svg_current
pptr-TabNote TabNote_Draw Bravura svg_reference
pptr-Strokes Strokes___Notation_and_Tab Bravura svg_current
pptr-Strokes Strokes___Notation_and_Tab Bravura svg_reference
pptr-Grace_Tab_Notes Grace_Tab_Note_Slurred Bravura svg_current
pptr-Grace_Tab_Notes Grace_Tab_Note_Slurred Bravura svg_reference
pptr-Grace_Tab_Notes Grace_Tab_Note_Simple Bravura svg_current
pptr-Grace_Tab_Notes Grace_Tab_Note_Simple Bravura svg_reference

@rvilarl rvilarl requested a review from ronyeh April 28, 2023 07:39
@rvilarl rvilarl marked this pull request as draft April 28, 2023 07:39
@rvilarl rvilarl marked this pull request as ready for review May 1, 2023 10:38
@rvilarl
Copy link
Collaborator Author

rvilarl commented May 2, 2023

I will merge this one that updates all the npm packages and then update the documentation directly on master.
@ronyeh I think we should make a release.

@rvilarl rvilarl merged commit ab68359 into 0xfe:master May 2, 2023
@rvilarl rvilarl mentioned this pull request May 2, 2023
Closed
@rvilarl rvilarl deleted the update/qunit branch May 7, 2023 18:26
@ronyeh ronyeh mentioned this pull request May 25, 2023
Closed
ronyeh added a commit to ronyeh/vexflow4 that referenced this pull request Jun 1, 2023
@ronyeh
tests/support/ no longer exists as of PR 0xfe#1562
d9f8714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronyeh ronyeh Awaiting requested review from ronyeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rvilarl