Prevent octave from being -0 when calculating key properties #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvilarl
approved these changes
Sep 15, 2023
|
Did this also get into the v5 main branch? |
|
There are two things that I have in my todo list, this one and a return value that was changed on reques of another user. |
sschmidTU
pushed a commit
to opensheetmusicdisplay/opensheetmusicdisplay
that referenced
this pull request
Sep 18, 2023
…h apparently -0 can cause issues on some systems. also, simpler. 0xfe/vexflow#1596 No changes in OSMD according to visual regression tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1595. -0 seems to cause issues on certain platforms/environments. There are other instances where -0 is possible throughout the codebase, but I wanted this PR to be as minimal as possible.