-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
priceAggregator, scaledPriceAuthority contracts are already installed #7
Comments
This has substantial impact on the cost (in IST) of deploying. Let's see if we can reduce that 10k IST estimate substantially. I have a list of mainnet1B-bundle-ids.md that are already on chain. I guess you should have the same info in a devnet node. When you have deployed recently, what's the size of the bundles that needed to go on chain? |
revised estimate: 4761.172 IST (pending confirmation of bundle hashes) since we can exclude scaledPriceAuthority and fluxAggregator
|
fluxAggregator contract bundle changed between stATOM2 and stATOM3perhaps due to... cc @turadg Neither is the same bundle as any on mainnet. We really should tweak the proposal so it uses the already-installed fluxAggregator contract installation (called
stATOM3 bundles on an explorerhttps://devnet.agoric.explorers.guru/account/agoric15xddzse9lq74cyt6ev9d7wywxerenxdgxsdc3m is handy: |
agoricdev-23 contract bundles don't match mainnetugh... starting devnet on agoric-upgrade-11 (Sep 5) doesn't actually match mainnet. mainnet started on mainnet1B-rc3 (Jun 9) and upgraded to -11. In particular, the fluxAggregator bundle is from 1B priceAggregator contract hash on agoricdev-23 doesn't match any in mainnet1B-bundle-ids.md From
|
Mainnet fluxAggregator:
|
bundle file | bundle hash | date | release | git hash | ||
---|---|---|---|---|---|---|
inter-protocol/bundles/bundle-fluxAggregatorKit.js | 4522bd0b71b615b612235d321977a1e906cd289e0962b106e7ba5718d0e94e25bc2c9e4be589c513c05c337c25a0c89c527b91322415cc80337fb2b2b0ccb75a | 2023-06-09 | mainnet1B-rc3 | ba3b77644 | ||
inter-protocol/bundles/bundle-scaledPriceAuthority.js | 0b2177975e88c7221b2fe635fdc75f518916ee42d959e9772dc77ef9775995f36cef50578a070708606e2c2431e66ee51d01147b10821aa5f1983e564697cccd | 2023-06-09 | mainnet1B-rc3 | ba3b77644 |
In particular, this permit to add/replace any entry in agoric-vault-collateral-proposal/add-stATOM-oracles-permit.json Lines 29 to 31 in c94d3fd
likewise, nor this one: agoric-vault-collateral-proposal/add-stATOM-permit.json Lines 22 to 28 in c94d3fd
|
agoric-vault-collateral-proposal/add-stATOM-oracles.js
Lines 41 to 42 in 1aa1b70
The installation is already available as
{ ... installation: { consume { priceAggregator } } }
.We should be able to take this part of
price-feed-proposal.js
out:likewise in
addAssetToVault.js
:The text was updated successfully, but these errors were encountered: