[FEATURE] Permettre de créer de nouvelles pages avec des slices sur Prismic (PIX-1169) #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celineung
force-pushed
the
PIX-1169-dynamic-slices-in-page
branch
2 times, most recently
from
3e08696
to
dc01a25
Compare
celineung
added
👀 Func Review Needed
team-evaluation
MelanieMEB
requested changes
Sep 2, 2020
celineung
force-pushed
the
PIX-1169-dynamic-slices-in-page
branch
from
dc01a25
to
f2544e0
Compare
celineung
force-pushed
the
PIX-1169-dynamic-slices-in-page
branch
2 times, most recently
from
f4f776f
to
1e5a03c
Compare
sbedeau
reviewed
Sep 4, 2020
celineung
force-pushed
the
PIX-1169-dynamic-slices-in-page
branch
6 times, most recently
from
1221e45
to
7ab74b2
Compare
MelanieMEB
approved these changes
Sep 4, 2020
celineung
force-pushed
the
PIX-1169-dynamic-slices-in-page
branch
from
7ab74b2
to
59df8e9
Compare
jbuget
suggested changes
Sep 7, 2020
sbedeau
approved these changes
Sep 7, 2020
|
Ok techniquement mais je n'ai pas réussi à tester fonctionnellement |
celineung
force-pushed
the
PIX-1169-dynamic-slices-in-page
branch
from
59df8e9
to
810bb76
Compare
jbuget
approved these changes
Sep 7, 2020
celineung
added
🚀 Ready to Merge
and removed
👀 Func Review Needed
👀 Tech Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
L'équipe de communication doit pouvoir, via Prismic, créer de nouvelles pages qui utilisent les nouveaux slices existants (Banner, Feature et Article).
🤖 Solution
_custom-page.vue, qui, en fonction du type de Custom Type (simple_pageouslices_page), appelera le composant SimplePage ou SliceZone🌈 Remarques
SimplePagea été déplacé danscomponents. Est-il nécessaire de le renommer?headeretfooterfiguraient sur le Custom Typesimple_pagede Prismic mais n'étaient pas prise en compte dans l'app. Par conséquent, ils ont été supprimés.✨ Review App
Test nouveau type de page avec slicesuridu document Prismichttps://pix-site-review-pr156.osc-fr1.scalingo.io/page-test-slices