Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout de l'ADR pour la migration de pix-pro dans pix-site #175

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

Laurentlcs
Copy link

@Laurentlcs Laurentlcs commented Sep 24, 2020

🦄 Problème

Comment suivre la décision d'architecture de la migration pix-pro dans pix-site.

🤖 Solution

Ajout de l'ADR expliquant le choix concernant la migration de pix-pro

🌈 Remarques

RAS

✨ Review App

RAS

Copy link
Contributor

@jbuget jbuget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci ❤️

docs/0001-pix-pro-migration.md Outdated Show resolved Hide resolved
docs/0001-pix-pro-migration.md Outdated Show resolved Hide resolved
docs/0001-pix-pro-migration.md Outdated Show resolved Hide resolved
@jbuget
Copy link
Contributor

jbuget commented Sep 24, 2020

chore (non-blocking): Je rajoute que sur Pix, les ADR sont dans un sous-répertoire docs/adr qui permet d'utiliser plus facilement des outils de gestion des ADRs comme ADR Tools.

@Laurentlcs Laurentlcs changed the title Ajout d'une ADR pour la migration de pix-pro dans pix-site Ajout de l'ADR pour la migration de pix-pro dans pix-site Sep 24, 2020
docs/0001-pix-pro-migration.md Outdated Show resolved Hide resolved
@bpetetot
Copy link
Contributor

@HEYGUL Oui on a dû modifier un peu pix-bot pour qu'il déploie pix-site et pix-pro à partir d'un seul repo.
J'ai expliqué les modifications dans cette PR de pix-bot: 1024pix/pix-bot#34
On ne mergera cette PR que quand on aura terminé la migration complète de pix-pro.

@bpetetot bpetetot merged commit d0b6ae4 into dev Sep 24, 2020
@bpetetot bpetetot deleted the add-adr-for-pix-pro-migration branch September 24, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants