[FEATURE] Ajouter la possibilité de mettre une vidéo sur Article (PIX-1310). #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbedeau
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
MelanieMEB
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
Je suis OK avec la PR.
La seule amélioration que j'ajouterais au vu du code actuelle, serait d'ajouter containsTextAndVideo dans les if d'affichage des images, pour ne pas les afficher s'il y a des vidéos.
On a soit pas d'image, soit une image, soit une vidéo, donc je pense qu'on peut faire cette limite en ajoutant && !containsTextAndVideo dans les v-if des images.
alexandrecoin
approved these changes
Oct 7, 2020
MelanieMEB
approved these changes
Oct 7, 2020
celineung
approved these changes
Oct 7, 2020
sbedeau
added
🚀 Ready to Merge
and removed
👀 Func Review Needed
👀 Tech Review Needed
labels
sbedeau
force-pushed
the
pix-1310-add-video-to-article
branch
from
294112d
to
fdea6e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Pour mettre en avant Pix de manière encore plus dynamique, nous avons besoin d'utiliser des vidéos.
🤖 Solution
Ajouter la possibilité d'interpréter des formats animés depuis Prismic via notre stockage OVH
🌈 Remarques
display: grid?✨ Review App
https://site-pr185.review.pix.fr/
https://pro-pr185.review.pix.fr/