[FEATURE] Avoir une navigation principale pour Pix Pro (PIX-1368). #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelanieMEB
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
MelanieMEB
force-pushed
the
pix-1368-navigation-for-pix-pro
branch
from
b01032a
to
0d5d0f3
Compare
MelanieMEB
commented
Oct 9, 2020
MelanieMEB
force-pushed
the
pix-1368-navigation-for-pix-pro
branch
from
7e315be
to
70f08dd
Compare
celineung
reviewed
Oct 12, 2020
|
Comment teste-on la sous-navigation? Je ne parviens pas à accéder à la page pix-pro. |
Si tu vas sur la review app Pro : la navigation ne dois pas changer. |
celineung
approved these changes
Oct 12, 2020
…ro or pix-site nav
MelanieMEB
force-pushed
the
pix-1368-navigation-for-pix-pro
branch
from
70f08dd
to
d9dcb13
Compare
|
I'm deploying this PR to these urls:
Please check it out! |
MelanieMEB
force-pushed
the
pix-1368-navigation-for-pix-pro
branch
from
d9dcb13
to
e5ed2bc
Compare
sbedeau
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Le site pro.pix va avoir sa propre navigation principale et n'utilisera plus les sub-nav.
🤖 Solution
navigation_foravec comme valeur pix-site/pix-pro sur le typeMain NavigationMain NavigationrépétableNavigationSliceZone, regrouper (par Lodash qui a été ajouté) les navigations par site utilisé, et prendre la première navigation proposé pour le site actuel🌈 Remarques
✨ Review App
https://site-pr190.review.pix.fr/
https://pro-pr190.review.pix.fr/