[FEATURE] Récupérer les meta descriptions depuis prismic. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm deploying this PR to these urls:
Please check it out! |
jonasgrilleres
force-pushed
the
fetch-meta-description-from-prismic
branch
6 times, most recently
from
feeea29
to
e677c0a
Compare
jonasgrilleres
changed the title
jonasgrilleres
force-pushed
the
fetch-meta-description-from-prismic
branch
from
e677c0a
to
aeeb00d
Compare
Anne-Gaelle-S
approved these changes
Feb 17, 2021
|
Cette methode necessite de definir des meta pour chaque page. On pourrais avoir un fallback pour pix-site et pix-org par langue |
aceol
approved these changes
Feb 17, 2021
jonasgrilleres
force-pushed
the
fetch-meta-description-from-prismic
branch
from
aeeb00d
to
b11e36e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Les meta descriptions proviennent du
package.jsonet il n'est pas possible de les changer pour chaque page.🤖 Solution
On récupère la meta description depuis prismic. Si elle n'est pas renseignée, on utilise une description générique.
💯 Pour tester
SSR_ENABLED=true npm run dev:siteRemplir une description dans l'onglet
Social Cardset voir qu'elle s'applique bien au tag<meta name="description" content="Ma description">Si rien n'est rempli, on doit y voir la phrase par défaut.