Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix affichage du favicon sur le site .org (PIX-2351). #267

Merged
merged 1 commit into from
May 12, 2021

Conversation

Thomasevano
Copy link
Contributor

@Thomasevano Thomasevano commented May 10, 2021

🦄 Problème

Le favicon n'apparait pas sur .org.

🤖 Solution

Ne pas rediriger le favicon lorsque le nom de domaine est en .org.

🌈 Remarques

R.A.S

💯 Pour tester

Se rendre sur pix-site et vérifier que le favicon est maintenant affiché.

@Thomasevano Thomasevano changed the title [BUGFIX] Fix affichage du favicon sur le site .org [BUGFIX] Fix affichage du favicon sur le site .org (PIX-2351). May 10, 2021
@pix-service
Copy link

I'm deploying this PR to these urls:

Please check it out!

Copy link
Contributor

@francois2metz francois2metz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜 💛 💚 💙 LGTM 💙 💚 💛 💜

@VincentHardouin
Copy link
Member

Il y a un tuto pour lancer le test.sh ?

@HEYGUL
Copy link
Contributor

HEYGUL commented May 11, 2021

Il y a un tuto pour lancer le test.sh ?

oui, dans le README

@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-2351-fix-favicon-display-on-org branch from bd2a125 to 47b6152 Compare May 12, 2021 07:44
@pix-service-auto-merge pix-service-auto-merge deleted the pix-2351-fix-favicon-display-on-org branch May 12, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Ready to Merge team-evaluation PR relatives à l'expérience d'évaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants