[FEAT] Ajout de Matomo à Pix Pro (PIX-2800). #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm deploying this PR to these urls:
Please check it out! |
alexandrecoin
changed the title
alexandrecoin
changed the title
|
La #277 ne faisait pas déjà cela ? |
francois2metz
approved these changes
Jul 13, 2021
celineung
approved these changes
Jul 13, 2021
VincentHardouin
approved these changes
Jul 19, 2021
alexandrecoin
added
🚀 Ready to Merge
Tech Review OK
and removed
👀 Tech Review Needed
labels
pix-service-auto-merge
force-pushed
the
tech-add-matomo-site-id-env-for-splitted-sites-analytics
branch
from
1f88b7b to
49d92b9
Compare
pix-service-auto-merge
deleted the
tech-add-matomo-site-id-env-for-splitted-sites-analytics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Dans l'optique d'ajouter Matomo à Pix Pro, nous devons associer la variable siteId au site correspondant (pix-site et pix-pro) et ainsi faire en sorte que la variable siteId nécessaire au plugin
nuxt-matomone soit plus codée en dur comme cela était le cas jusqu'à présent.🤖 Solution
Ajout d'une variable d'environnement
MATOMO_SITE_IDet de la vérification de sa présence.🌈 Remarques
Nous n'avons pas trouvé d'info quant à la gestion d'erreur dans le fichier de config.
Peut-être remplacer le console.warn par un throw d'erreur ferait l'affaire ? Une meilleure option ?
💯 Pour tester
N/A