Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Fixer la version de assets-extractor-module #315

Merged

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Oct 29, 2021

🦄 Problème

Le package-lock.json est modifié quand on fait un npm install.

🤖 Solution

Fixer la version de assets-extractor-module sur un hash précis pour le moment.

🌈 Remarques

Il faudra faire une release npm de assets-extractor-module pour que ce soit plus propre.

💯 Pour tester

Faire un npm install et vérifier que le package-lock.json ne change pas.

@nlepage nlepage added 👀 Tech Review Needed cross-team Toutes les équipes de dev labels Oct 29, 2021
@nlepage nlepage self-assigned this Oct 29, 2021
@pix-service
Copy link

I'm deploying this PR to these urls:

Please check it out!

@pix-service-auto-merge pix-service-auto-merge force-pushed the tech/pin-assets-extractor-module-version branch from 8ca94d6 to e0bf0b5 Compare October 29, 2021 13:33
@pix-service-auto-merge pix-service-auto-merge deleted the tech/pin-assets-extractor-module-version branch October 29, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-team Toutes les équipes de dev 🚀 Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants