[BUGFIX] Affichage de la vidéo au scroll sur la page d'accueil #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbertrand
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
|
I'm deploying this PR to these urls:
Please check it out! |
nlepage
approved these changes
Oct 29, 2021
VincentHardouin
approved these changes
Nov 2, 2021
VincentHardouin
added
🚀 Ready to Merge
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
pix-service-auto-merge
force-pushed
the
fix-video-display-page-banner
branch
from
4d4c145 to
9c04adb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
La vidéo de la page d'accueil semblait passer sous le contenu du site.
🤖 Solution
Déplacement de l'image de fond de la
PageBannerpour ne pas avoir besoin duclip-path. L'image gère elle même l'effet arrondi.🌈 Remarques
Le soucis venait du
clip-pathsur lePageBanner. On ne met la couleur de fond bleu seulement si il n'y a pas d'image précisée.💯 Pour tester
PageBannersont correctes sur Pix pro/Pix Org