-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Améliorer la lisibilité des configurations des modules #441
Merged
pix-service-auto-merge
merged 7 commits into
dev
from
sr-config-declaration-in-nuxt-config
Dec 19, 2022
Merged
[TECH] Améliorer la lisibilité des configurations des modules #441
pix-service-auto-merge
merged 7 commits into
dev
from
sr-config-declaration-in-nuxt-config
Dec 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm deploying this PR to these urls:
Please check it out! |
VincentHardouin
added
the
team-evaluation
PR relatives à l'expérience d'évaluation
label
Dec 15, 2022
yannbertrand
approved these changes
Dec 15, 2022
lego-technix
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ce rangement me parait aussi plus clair, bien que je ne connaisse pas assez Nuxt pour pouvoir bien juger, et J'ai vérifié fonctionnellement qu'il n'y avait pas de régression.
reibecca
approved these changes
Dec 16, 2022
VincentHardouin
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
Dec 19, 2022
pix-service-auto-merge
deleted the
sr-config-declaration-in-nuxt-config
branch
December 19, 2022 08:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Actuellement, nous configurons les modules que nous utilisons de 2 manières différentes, ce qui créé de la complexité à la lecture et de la confusion lors de l'ajout d'un nouveau module
🤖 Solution
🌈 Remarques
💯 Pour tester