[TECH] Ajouter des tests sur le language switcher #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentHardouin
force-pushed
the
tech-add-snapshot-test-for-language-switcher
branch
from
c30c29c
to
3426b7b
Compare
|
I'm deploying this PR to these urls:
Please check it out! |
VincentHardouin
added
the
team-evaluation
yannbertrand
force-pushed
the
tech-add-snapshot-test-for-language-switcher
branch
from
3426b7b
to
d38fd9b
Compare
lego-technix
approved these changes
Dec 22, 2022
yannbertrand
approved these changes
Dec 22, 2022
| const $i18n = { locale: 'fr-fr' } | ||
|
|
||
| // when | ||
| const wrapper = mount(LanguageSwitcher, { |
There was a problem hiding this comment.
Question : pourquoi passer sur le mount plutôt que shallowMount ?
There was a problem hiding this comment.
mount permet d'avoir le dom des composants enfants, ce que ne fait pas shallowMount
yannbertrand
force-pushed
the
tech-add-snapshot-test-for-language-switcher
branch
from
d38fd9b
to
19f3747
Compare
reibecca
approved these changes
Dec 22, 2022
VincentHardouin
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
pix-service-auto-merge
deleted the
tech-add-snapshot-test-for-language-switcher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Le language switcher est à mon gout pas suffisament tester pour que je puisse le refactorer en toute aisance
🤖 Solution
Ajouter des tests snapshots pour couvrir l'affichage actuelle
🌈 Remarques
On peut relever qu'un test a été supprimé car il ne servait plus, n'ayant plus de différence entre pro.pix.org et pro.pix.fr
💯 Pour tester