[TECH] Ne plus ajouter de lien vers la review-app dans la pull-request #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles ici. |
mickaelalibert
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
pix-service-auto-merge
deleted the
tech-remove-duplicated-pull-request-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Un lien vers la review-app est ajouté dans la pull-request.
Cela est lié à l'infrastructure (PaaS) et pas vraiment au métier.
De plus, cela oblige à accéder au token Github à plusieurs endroits.
🎁 Proposition
Le faire dans pix-bot 1024pix/pix-bot#202.
Ne plus le faire dans le monorepo.
🌟 Remarques
Supprimer la variable d'environnement
GITHUB_USER_TOKENdans le template des RA.🎅 Pour tester
Merger la PR et vérifier qu'un seul commentaire est posté.