[BUGFIX] Eviter l'erreur de déploiement quand une URL de la navigation n'est pas encore définie #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-site-review-pr475/environment |
octo-topi
changed the title
yannbertrand
force-pushed
the
fix-avoid-deployment-error
branch
from
587c3cd to
fca0c7c
Compare
yannbertrand
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥚 Problème
Si le contenu Prismic est publié avec un lien dans la navbar sans URL, impossible de développer/builder.
🥣 Proposition
Gérer ce cas pour éviter de crasher le build. La proposition consiste en filtrer les URLs qui ne sont pas définies dans la méthode permettant de savoir si on est sur le lien actif ou non.
🥛 Remarques
Potentiellement ça rendra des trucs bizarres en prod mais c'est la comm qui gère.
Ajouté 2 tests auto sur la méthode qui throwait.
🧈 Pour tester
Vérifier que je n'ai pas fait n'importe quoi.