[DOC] Documenter les nouvelle variables d'env de pix-site introduites pour la géolocalisation (PIX-7200) #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lego-technix
force-pushed
the
pix-7200-document-new-nginx-env-variables
branch
from
f056cc3
to
ffa2ea9
Compare
VincentHardouin
approved these changes
Feb 20, 2023
lego-technix
force-pushed
the
pix-7200-document-new-nginx-env-variables
branch
from
ffa2ea9
to
518090f
Compare
mickaelalibert
approved these changes
Feb 20, 2023
Co-authored-by: Mickael Alibert <mickaelalibert@users.noreply.github.com>
lego-technix
force-pushed
the
pix-7200-document-new-nginx-env-variables
branch
from
465bd72
to
aadbb8e
Compare
pix-service-auto-merge
deleted the
pix-7200-document-new-nginx-env-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
De nouvelles variables d’env nécessaires au fonctionnement de pix-site ont été ajouté par #502 mais elles n’ont pas été documentées.
🤖 Proposition
Ajouter ces trois variables d’environnement au README de pix-site en précisant leur utilité (demander aux captains si besoin) et en précisant qu’elles sont utilisées par le configuration nginx :
NGINX_GEOAPI_UPSTREAM_HOST(obligatoire)NGINX_GEOAPI_UPSTREAM_MAX_FAILS(facultatif)NGINX_GEOAPI_UPSTREAM_FAIL_TIMEOUT(facultatif)🌈 Remarques
RAS
💯 Pour tester
Demander une relecture aux captains.