[TECH] Corrige un warning sur l'usage du nextTick
#510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentHardouin
approved these changes
Feb 20, 2023
lego-technix
approved these changes
Feb 20, 2023
yannbertrand
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
On importe la dépendance
Vuepour utiliser la méthodenextTick. Le linter nous conseille d'importer uniquement la méthode (j'imagine pour du three shaking).🤖 Proposition
Directement utiliser la méthode
wrapper.vm.$nextTick()pour ne pas avoir besoin d'importer quoi que ce soit.🌈 Remarques
Aucune idée de si c'est une bonne pratique ou non mais ça corrige l'erreur de lint.
💯 Pour tester
Vérifier que la CI passe toujours.