[TECH] Améliorer la condition d'affichage précisant si la locale est international dans le locale switcher en affichage réduit (PIX-8230) #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-site-review-pr542/environment |
annemarie35
reviewed
Jun 2, 2023
Thomasevano
force-pushed
the
pix-8230-update-condition-to-display-international-mention-in-locale-switcher
branch
from
0d08b3b
to
6e613f4
Compare
annemarie35
approved these changes
Jun 5, 2023
annemarie35
approved these changes
Jun 5, 2023
igorissen
approved these changes
Jun 5, 2023
Thomasevano
added
🚀 Ready to Merge
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
in the locale switcher Co-authored-by: Anne-Marie Esteves <anne-marie.esteves@octo.com> Co-authored-by: Ismael Gorissen <ismael.gorissen@gmail.com> Co-authored-by: Eric Lim <eric.lim@zenika.com>
pix-service-auto-merge
force-pushed
the
pix-8230-update-condition-to-display-international-mention-in-locale-switcher
branch
from
6e613f4
to
aee55eb
Compare
pix-service-auto-merge
deleted the
pix-8230-update-condition-to-display-international-mention-in-locale-switcher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
La condition permettant d'afficher la mention
international -se basait sur l'iconegloabel-europe.svg. Elle est donc dépendant du nom de l'icone.🤖 Proposition
Comme évoqué dans la PR #537. Il est mieux de se baser sur le
localCodeafin de déterminer si locale est internationale.localeCode:enest international et doit donc comporter la mention.localeCode:fr-ben'est pas international et ne doit pas comporter la mention.🌈 Remarques
R.A.S
💯 Pour tester
international -se trouve seulement devantFrancaisetEnglish