[FEATURE] Créer le nouveau menu (PIX-8994) #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-site-review-pr579/environment |
clarissedmn
force-pushed
the
pix-8984-create-new-navigation-menu
branch
6 times, most recently
from
9d7e0cd to
2eabff8
Compare
clarissedmn
force-pushed
the
pix-8984-create-new-navigation-menu
branch
from
8c3f4bb to
8c2b4a6
Compare
…change separator design
clarissedmn
force-pushed
the
pix-8984-create-new-navigation-menu
branch
from
3367b41 to
b0205f6
Compare
matthiasferraina
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
|
Les différences de texte/contenu, j'imagine que ce n'est pas dans le scope de la PR ? (Concernant Pix Emploi / Vous êtes, par exemple) |
|
Je n'ai pas réussi à aller activer le feature toggle pour Pix Pro et donc pas pu tester sur Pix Pro |
clarissedmn
force-pushed
the
pix-8984-create-new-navigation-menu
branch
from
b0205f6 to
b2dcd4e
Compare
AlexNaudyy
approved these changes
Oct 9, 2023
clarissedmn
commented
Oct 9, 2023
clarissedmn
commented
Oct 9, 2023
La-toile-cosmique
approved these changes
Oct 9, 2023
clarissedmn
force-pushed
the
pix-8984-create-new-navigation-menu
branch
2 times, most recently
from
8ef9f71 to
7f0a7e0
Compare
clarissedmn
force-pushed
the
pix-8984-create-new-navigation-menu
branch
from
7f0a7e0 to
a59ed55
Compare
clarissedmn
added
Func Review OK
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Nous avons besoin d'un nouveau design pour le header et menu de navigation.
Lien vers les designs
🤖 Proposition
En fonction du feature toggle, afficher de nouveaux composants avec un nouveau design.
🌈 Remarques
💯 Pour tester
Aller sur la RA et vérifier l'affichage du nouveau menu.