[BUGFIX] Corriger la preview Prismic sur les fragments de documents (PIX-11601) #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-site-review-pr637/environment |
er-lim
changed the title
er-lim
force-pushed
the
pix-11601-fix-prismic-fragment-preview
branch
from
653eedf to
93605c9
Compare
er-lim
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
🚧 Development in progress
labels
er-lim
added
Func Review OK
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
👀 Func Review Needed
🚀 Ready to Merge
labels
er-lim
force-pushed
the
pix-11601-fix-prismic-fragment-preview
branch
from
93605c9 to
61e3817
Compare
pix-service-auto-merge
deleted the
pix-11601-fix-prismic-fragment-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Actuellement la preview Prismic ne fonctionne pas sur les documents qui sont des fragments (ex: footer, nav...).
Elle retourne un
undefineddans l'url🤖 Proposition
Faire fonctionner la preview sur ces documents en corrigeant ce comportement.
🌈 Remarques
RAS
💯 Pour tester
French FranceReproduire le bug
Integrationdans la liste des preview/undefinedet que la page ne s'affiche pas correctementFix
PR 637 frdans la liste des preview/et que la home s'affiche bien.