[TECH] Arranger encore l'utilisation de playwright (PIX-4174) #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bérengère Claudeau <berengere.claudeau@pix.fr> Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
Co-authored-by: Bérengère Claudeau <berengere.claudeau@pix.fr> Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-site-review-pr706/environment |
clemlatz
approved these changes
Sep 6, 2024
BerengereC
reviewed
Sep 6, 2024
Co-authored-by: Clément Latzarus <clement.latzarus@pix.fr> Co-authored-by: Bérengère Claudeau <berengere.claudeau@pix.fr> Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
Co-authored-by: Clément Latzarus <clement.latzarus@pix.fr> Co-authored-by: Bérengère Claudeau <berengere.claudeau@pix.fr> Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
lego-technix
force-pushed
the
pix-14174-arrange-playwright-use
branch
6 times, most recently
from
5e939f5
to
f027114
Compare
Co-authored-by: Clément Latzarus <clement.latzarus@pix.fr> Co-authored-by: Bérengère Claudeau <berengere.claudeau@pix.fr> Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
lego-technix
force-pushed
the
pix-14174-arrange-playwright-use
branch
from
f027114
to
03332ea
Compare
BerengereC
approved these changes
Sep 10, 2024
lego-technix
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Actuellement l'utilisation des tests end-to-end (e2e) de pix-site par les développeurs est problématique : sur les postes de développement les tests e2e finissent toujours en erreur et on ne reproduit donc pas les mêmes comportements que sur la CI. De plus on ne comprend pas pourquoi-comment la CI peut passer alors que des tests sont en erreur.
🤖 Proposition
npx🌈 Remarques
RAS
💯 Pour tester
Lire la documentation ajoutée et vérifier qu'elle est compréhensible et aide par rapport à la situation initiale
En local exécuter la commande suivante et vérifier que c'est un succès (
echo $?doit valoir0), alors qu'auparavant cette commande aurait renvoyé un code d’erreur :